Merged
Conversation
also make indentation consistent
Contributor
Author
|
Since your project is also based on Meson, you could also publish TMXLite as a wrapdb package. Here's an example of what you'd need to PR to the meson wrapdb repo:
Ofc, you can read more in the docs if interested: https://mesonbuild.com/Wrap-dependency-system-manual.html |
Owner
|
Thank you! That's massively appreciated! I'll get this merged and released when I get home tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build only tested with MSVC locally with no test runs, will need runners
The Important Stuff
Fixing Warnings
-Doptimization=3instead of-O3to satisfy Meson builds-1to auint32_tso it isn't implicituint16_tnodetochildNodeto not shadow function param nameExtras