Clarify that animation tile ID is GID actually#181
Merged
fallahn merged 1 commit intofallahn:masterfrom Jan 16, 2026
Merged
Conversation
Owner
|
Thanks! Sorry for the confusion 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development I had some confusion and errors because of this line:
tmxlite/tmxlite/src/Tileset.cpp
Line 447 in e121599
I did not expect that member named
tileIDwill actually contain a global ID (local + firstGID), and seems that such logic does not apply to regulartmx::Tileset::Tile.IDor terrain tile value. So I added a documentation note so that end user will not add the firstGID twice, as I did mistakenly.