fix(plugins/cloudtrail): support for assumedrole in cloudtrail#1247
Conversation
|
Welcome @fcracker79! It looks like this is your first PR to falcosecurity/plugins 🎉 |
6ad9a7e to
688108d
Compare
|
@legobrick: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ekoops
left a comment
There was a problem hiding this comment.
Hey, thank you for this contribution! 😄
This introduces a change in the field, behaviour, so we should document it in
Could you please modify the field description and re-generate the couldtrail plugin's
README.md accordingly?
… back to the identity userName Signed-off-by: Mirko Bonasorte <mirko.bonasorte@sysdig.com>
… back to the identity userName Signed-off-by: Mirko Bonasorte <mirko.bonasorte@sysdig.com>
cb03793 to
eaf1072
Compare
|
LGTM label has been added. DetailsGit tree hash: 3ec49c510cfb57717d7f7cd9e5ffe5b001908c81 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, fcracker79, legobrick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area plugins
What this PR does / why we need it:
The PR ensures that the
ct.userfield is correctly populated in case of assumed role.It does the following attempts:
userIdentity.arnfield and extracts the session nameuserIdentity.principalIdand takes the role session nameuserIdentity.sessionContext.sessionIssuer.userNamefield