Skip to content

Conversation

@lubieowoce
Copy link
Contributor

@lubieowoce lubieowoce commented Jan 22, 2026

Manually stacked on #35506

Currently, IO that finished before the request started is not considered IO:

const ioInfo = info.awaited;
if (ioInfo.end <= request.timeOrigin) {
// This was already resolved when we started this render. It must have been some
// externally cached data. We exclude that information but we keep components and
// awaits that happened inside this render but might have been deduped within the
// render.

This leads to loss of debug info when a flight stream is deserialized and serialized again.
We can solve this by allowing "when the the request started" to be set to a point in the past, when the original stream started by doing

ReactServer.renderToReadableStream(..., { startTime: someTimestampInThePast })

I'm not entirely sure about this approach, because it doesn't compose very well. It works in the case where you know you're re-encoding an existing stream and can pass in its startTime. It might get weirder if you're also rendering new content alongside it.

@meta-cla meta-cla bot added the CLA Signed label Jan 22, 2026
@react-sizebot
Copy link

react-sizebot commented Jan 22, 2026

Comparing: 6a0ab4d...7367c43

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.67 kB 608.67 kB = 107.63 kB 107.64 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.11% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.60 kB 674.60 kB = 118.57 kB 118.58 kB
facebook-www/ReactDOM-prod.classic.js = 694.04 kB 694.04 kB = 122.00 kB 122.01 kB
facebook-www/ReactDOM-prod.modern.js = 684.43 kB 684.43 kB = 120.40 kB 120.40 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.73% 143.70 kB 144.74 kB +0.85% 25.64 kB 25.86 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.73% 143.70 kB 144.74 kB +0.85% 25.64 kB 25.86 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.72% 145.79 kB 146.83 kB +0.92% 26.10 kB 26.34 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.58% 196.96 kB 198.10 kB +0.64% 35.59 kB 35.82 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.58% 196.96 kB 198.10 kB +0.64% 35.59 kB 35.82 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js +0.57% 199.07 kB 200.21 kB +0.57% 36.03 kB 36.24 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.57% 200.66 kB 201.80 kB +0.60% 36.09 kB 36.31 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.57% 200.66 kB 201.80 kB +0.60% 36.09 kB 36.31 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.56% 202.75 kB 203.89 kB +0.57% 36.52 kB 36.73 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.56% 204.75 kB 205.89 kB +0.57% 36.90 kB 37.11 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.56% 204.75 kB 205.89 kB +0.57% 36.90 kB 37.11 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.56% 205.22 kB 206.36 kB +0.58% 37.01 kB 37.22 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.56% 205.22 kB 206.36 kB +0.58% 37.01 kB 37.22 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.55% 206.85 kB 207.99 kB +0.52% 37.34 kB 37.53 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.55% 207.33 kB 208.47 kB +0.52% 37.45 kB 37.64 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.55% 208.48 kB 209.62 kB +0.56% 37.40 kB 37.61 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.55% 208.48 kB 209.62 kB +0.56% 37.40 kB 37.61 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.55% 208.48 kB 209.62 kB +0.56% 37.40 kB 37.61 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.55% 208.48 kB 209.62 kB +0.56% 37.40 kB 37.61 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.55% 230.04 kB 231.30 kB +0.50% 41.07 kB 41.28 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.55% 230.04 kB 231.30 kB +0.50% 41.07 kB 41.28 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.54% 210.57 kB 211.71 kB +0.55% 37.82 kB 38.03 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.54% 210.57 kB 211.71 kB +0.53% 37.83 kB 38.03 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js +0.54% 232.13 kB 233.39 kB +0.47% 41.53 kB 41.72 kB
oss-stable-semver/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js +0.53% 236.70 kB 237.96 kB +0.52% 42.13 kB 42.34 kB
oss-stable/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js +0.53% 236.70 kB 237.96 kB +0.52% 42.13 kB 42.34 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.53% 237.90 kB 239.15 kB +0.50% 42.44 kB 42.65 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.53% 237.90 kB 239.15 kB +0.50% 42.44 kB 42.65 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.53% 237.95 kB 239.20 kB +0.50% 42.43 kB 42.64 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.53% 237.95 kB 239.20 kB +0.50% 42.43 kB 42.64 kB
oss-experimental/react-server-dom-unbundled/cjs/react-server-dom-unbundled-server.node.development.js +0.53% 238.79 kB 240.05 kB +0.47% 42.60 kB 42.80 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.52% 239.99 kB 241.24 kB +0.45% 42.91 kB 43.10 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.52% 240.04 kB 241.29 kB +0.47% 42.91 kB 43.11 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.52% 223.52 kB 224.68 kB +0.50% 40.47 kB 40.68 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.52% 223.52 kB 224.68 kB +0.50% 40.47 kB 40.68 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.51% 225.61 kB 226.77 kB +0.48% 40.92 kB 41.12 kB

Generated by 🚫 dangerJS against 7367c43

@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch 3 times, most recently from 32f22fc to 4bdc1b0 Compare January 22, 2026 15:36
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch from 4bdc1b0 to 7367c43 Compare January 22, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants