-
Notifications
You must be signed in to change notification settings - Fork 50.4k
[Flight] Allow overriding request.timeOrigin
#35598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lubieowoce
wants to merge
6
commits into
facebook:main
Choose a base branch
from
lubieowoce:preserve-old-io-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+674
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32f22fc to
4bdc1b0
Compare
4bdc1b0 to
7367c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually stacked on #35506
Currently, IO that finished before the request started is not considered IO:
react/packages/react-server/src/ReactFlightServer.js
Lines 5338 to 5343 in 6a0ab4d
This leads to loss of debug info when a flight stream is deserialized and serialized again.
We can solve this by allowing "when the the request started" to be set to a point in the past, when the original stream started by doing
I'm not entirely sure about this approach, because it doesn't compose very well. It works in the case where you know you're re-encoding an existing stream and can pass in its startTime. It might get weirder if you're also rendering new content alongside it.