Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 21, 2026

Summary

SubmitEvent.submitter is widely supported so we should expose it. We assume submitter is supported since #29028.

This doesn't include a polyfill for older browsers.

Closes #33033

How did you test this change?

  • added tests which fail without adding SubmitEventInterface

@meta-cla meta-cla bot added the CLA Signed label Jan 21, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 21, 2026
@eps1lon eps1lon force-pushed the sebbie/01-21-_react-dom_include_submitter_in_submit_events branch from e93247e to e87d02a Compare January 21, 2026 20:12
@react-sizebot
Copy link

Comparing: cdbd55f...e87d02a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.04% 608.67 kB 608.90 kB +0.03% 107.63 kB 107.66 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.04% 674.60 kB 674.84 kB +0.04% 118.57 kB 118.62 kB
facebook-www/ReactDOM-prod.classic.js +0.03% 694.04 kB 694.28 kB +0.02% 122.01 kB 122.04 kB
facebook-www/ReactDOM-prod.modern.js +0.03% 684.43 kB 684.67 kB +0.02% 120.40 kB 120.43 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e87d02a

@eps1lon eps1lon marked this pull request as ready for review January 21, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: form submit event does not expose event.submitter

2 participants