Add test targets to the CMake build#475
Open
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Extend the CMake build system added in D91269570 to also build / run tests. I mainly went for one listfile per subdirectory but lumped in smaller disparate tests under mcrouter/lib into a single target for simplicity. I omitted tests under mcrouter/lib/carbon/ as their utility for OSS mcrouter is limited compared to the scaffolding needed to run them (they interdepend on utilities from mcrouter/lib/network/test). No changes to existing test files beyond the minimum needed to fix compilation, so there are many expected failures in an OSS run. Tested using a fresh copy of fbcode_builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the CMake build system added in D91269570 to also build / run tests. I mainly went for one listfile per subdirectory but lumped in smaller disparate tests under mcrouter/lib into a single target for simplicity. I omitted tests under mcrouter/lib/carbon/ as their utility for OSS mcrouter is limited compared to the scaffolding needed to run them (they interdepend on utilities from mcrouter/lib/network/test).
No changes to existing test files beyond the minimum needed to fix compilation, so there are many expected failures in an OSS run.
Tested using a fresh copy of fbcode_builder.