Skip ServiceRouter tests when SR is not linked#466
Open
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Open
Skip ServiceRouter tests when SR is not linked#466mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Conversation
SR is an optional dependency for mcrouter, especially OSS, so skip tests exercising SR-specific functionality in the OSS build.
mszabo-wikia
force-pushed
the
skip-servicerouter-tests
branch
from
bd8dcaf to
430709e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SR is an optional dependency for mcrouter, especially OSS, so skip tests exercising SR-specific functionality in the OSS build.