Fix: Add cxxabi fallback to buffer-based demangle function#2582
Open
SHH123-crypto wants to merge 1 commit intofacebook:mainfrom
Open
Fix: Add cxxabi fallback to buffer-based demangle function#2582SHH123-crypto wants to merge 1 commit intofacebook:mainfrom
SHH123-crypto wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
SHH123-crypto
force-pushed
the
fix-demangle-cxxabi-fallback
branch
from
2e075c3 to
60fb359
Compare
The buffer-based demangle() function now falls back to cxxabi when libiberty is not available, matching the behavior of the string-based version. This ensures stack traces are readable even without binutils-dev. Key changes: - Pass the user-provided buffer to __cxa_demangle instead of nullptr - This avoids allocation while still enabling demangling - Maintains async-signal-safety as required for signal handlers - Updates tests to expect demangling with either liberty or cxxabi Fixes facebook#2546
Contributor
|
The overload of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2546
The buffer-based demangle() function now falls back to cxxabi when libiberty is not available, matching the behavior of the string-based version. This ensures stack traces are readable even without binutils-dev.