feat(oss/python): make iobuf available via facebook CMakeLists.txt#2505
Open
ben-- wants to merge 3 commits intofacebook:mainfrom
Open
feat(oss/python): make iobuf available via facebook CMakeLists.txt#2505ben-- wants to merge 3 commits intofacebook:mainfrom
ben-- wants to merge 3 commits intofacebook:mainfrom
Conversation
This was referenced Sep 18, 2025
ben--
force-pushed
the
oss-python-iobuf
branch
from
578328d to
8dfe02a
Compare
Use find_package(Boost) without MODULE to use modern Boost targets instead of legacy FindBoost.cmake variables.
ben--
force-pushed
the
oss-python-iobuf
branch
5 times, most recently
from
4de618d to
38c72f5
Compare
fix(oss): make folly/defs.bzl available in OSS build
ben--
force-pushed
the
oss-python-iobuf
branch
from
38c72f5 to
1f3459a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2503 and must land after it.
Make iobuf available to python code through fbcode_build and cmake.
This code was tested by compiling this version of folly into fbthrift and sapling/edenfs. Without it, some upcoming changes to the sapling codebase would not compile.