[Nexthop] Support PXE boot with an authoritative DHCPv6 server#984
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Support PXE boot with an authoritative DHCPv6 server#984travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> It's common for networks which use IPv6 to have a pre-existing, authoritative DHCPv6 server. In such cases the Distro Infra should not supply its own DHCPv6 server since it will at best conflict with the authoritative server and at worst be entirely ignored. Add an argument which notifies the Distro Infra of this situation so it doesn't not supply DHCPv6. Instead the authoritative server will need to respond with the necessary bootfile-url option value, as is now described in the documentation. Further, since we cannot rely on an external DHCPv6 server to change its configuration and not respond with the PXE boot configuration after a successful PXE boot, this PR also removes the first PXE boot stage files so a subsequent PXE boot will fail over to the next boot option rather than re-execute the PXE installer. This is done now because without ProxyDHCPv6 support Meta requires this type of cooperation with a pre-existing network DHCPv6 server. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR --> Manually test against Minipack3 that when the --nodhcpv6 option is present, no DHCPv6 is supplied (and PXE boot fails). Further I manually tested that when I manually removed the ipxev?.efi files but still had the Distro Infra supply DHCPv6 that the PXE boot would fail and fall back to the second boot option.
travisb-nexthop
force-pushed
the
distro_infra_auth_dhcpv6
branch
from
6779eab to
710782b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
It's common for networks which use IPv6 to have a pre-existing, authoritative DHCPv6 server. In such cases the Distro Infra should not supply its own DHCPv6 server since it will at best conflict with the authoritative server and at worst be entirely ignored.
Add an argument which notifies the Distro Infra of this situation so it doesn't not supply DHCPv6. Instead the authoritative server will need to respond with the necessary bootfile-url option value, as is now described in the documentation.
Further, since we cannot rely on an external DHCPv6 server to change its configuration and not respond with the PXE boot configuration after a successful PXE boot, this PR also removes the first PXE boot stage files so a subsequent PXE boot will fail over to the next boot option rather than re-execute the PXE installer.
This is done now because without ProxyDHCPv6 support Meta requires this type of cooperation with a pre-existing network DHCPv6 server.
Test Plan
Manually test against Minipack3 that when the --nodhcpv6 option is present, no DHCPv6 is supplied (and PXE boot fails). Further I manually tested that when I manually removed the ipxev?.efi files but still had the Distro Infra supply DHCPv6 that the PXE boot would fail and fall back to the second boot option.