[Nexthop] Distro Infra: Support multiple CPU interfaces#983
Open
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
[Nexthop] Distro Infra: Support multiple CPU interfaces#983travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
travisb-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
If a CPU board has multiple network interfaces, it may be that the externally facing management port is not discovered as net0 by iPXE. In that case net1 will be the external port and will get an IP, but the autoexec.ipxe script will attempt to retrieve the installer using the MAC address of the non-external interface. Use netX instead, which represents the last successful interface to be 'opened' and be assigned and IP address. Successfully PXE booted fboss103 with these modifications. fboss103 started enumerating the internal interface to the BMC as net0 sometime recently..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
If a CPU board has multiple network interfaces, it may be that the externally facing management port is not discovered as net0 by iPXE. In that case net1 will be the external port and will get an IP, but the autoexec.ipxe script will attempt to retrieve the installer using the MAC address of the non-external interface.
Use netX instead, which represents the last successful interface to be 'opened' and be assigned and IP address.
Test Plan
Successfully PXE booted fboss103 with these modifications. fboss103 started enumerating the internal interface to the BMC as net0 sometime recently. Prior to this change it would fail because it did not receive any DHCP response from the BMC.