fix(oss): update prelude to support OSS folly build with buck2#1196
Open
ben-- wants to merge 12 commits intofacebook:mainfrom
Open
fix(oss): update prelude to support OSS folly build with buck2#1196ben-- wants to merge 12 commits intofacebook:mainfrom
ben-- wants to merge 12 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D90281806. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
Author
|
Not sure if the internal build has hung or if it is just taking its time. But, if there are issues, I'm happy to work on them if they can be shared here. |
ben--
force-pushed
the
oss-folly
branch
2 times, most recently
from
b4242e0 to
99b4dcc
Compare
ben--
force-pushed
the
oss-folly
branch
3 times, most recently
from
f4afc65 to
fcbf86e
Compare
Prior to this change, the code was assuming not artifacts directory existed and a `mkdir` command was failing. It wouldn't fail on GitHub, it would only fail if the same container was used twice (as would be more common on a developer workstation). This change just recursively removes that directory, so there isn't any risk of artifacts getting intermingled.
NB: The test failures seem centered around concurrency, suggesting that
there may be a shared root cause. Perhaps something in docker or
Apple's x86_64 Rosetta emulation?
This change disables code that can't compile or run reliably in OSS
builds.
"Unreliable" code was determined using the do/build script which
leverages nektos act to run the GitHub workflows locally.
The code was (largely) disabled using `#[cfg(fbcode_build)]` except for
areas where a oss/non-oss switch was required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates several parts of the prelude so that buck2 properly supports an OSS folly build.
The resulting version of buck2 is demonstrated working in folly #2542 which is a non-landable version of folly #2541 that shows the working builds.