feat: 支持 vite-imagetools 6.x#2
Open
jhygreatbug wants to merge 6 commits intoexplore-frontend:mainfrom
Open
Conversation
jhygreatbug
commented
Nov 20, 2023
jhygreatbug
commented
- vite-imagetools 6.x 数据结构发生变化
- 字段名称 fallback -> img
- sources 简化成字符串数组
- 测试 demo 增加 vite-imagetools 配置
Contributor
|
readme 里有相关的部分也改一下吧 |
Amorites
reviewed
Nov 20, 2023
| }; | ||
| }; | ||
|
|
||
| // v6.0.0以下 |
Amorites
reviewed
Nov 20, 2023
packages/picture/README.md
Outdated
| ## 使用 | ||
|
|
||
| > 建议配合 (vite-plugin-image-presets) 使用 | ||
| > 建议配合 [vite-plugin-image-presets](github.com/ElMassimo/vite-plugin-image-presets) 或 [vite-imagetools](https://github.com/JonasKruckenberg/imagetools/tree/main/packages/vite) 使用 |
Contributor
There was a problem hiding this comment.
vite-plugin-image-presets 相关的东西都去掉吧，现在不建议了
packages/picture/README.md
Outdated
| ```ts | ||
| interface PictureProp { | ||
| src: ImgHTMLAttributes[]; | ||
| src: Array<ImagePresetPictureOption | ImageToolsPictureOption | ImageToolsPictureOptionOld>; |
Amorites
reviewed
Nov 21, 2023
| w?: number; | ||
| }[]; | ||
| }; | ||
| img: ImageToolsPictureOptionImg; |
Author
There was a problem hiding this comment.
ImageToolsPictureOptionOld 吗，是 4.x 和 5.x 的类型，跟最新的 6.x 区分了下
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.