fix: allow user to override default record stats meter attributes#71
Open
alessio-perugini wants to merge 1 commit intoexaring:mainfrom
Open
fix: allow user to override default record stats meter attributes#71alessio-perugini wants to merge 1 commit intoexaring:mainfrom
alessio-perugini wants to merge 1 commit intoexaring:mainfrom
Conversation
Default metric attribute was appended at the end, making it impossible to override the default one from the user provided StatsOption. This commit ensure the default attributes, are always provided at the beginning, making it possible for the user to override those.
alessio-perugini
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default metric attribute was appended at the end, making it impossible to override the default one from the user provided StatsOption. This commit ensure the default attributes, are always provided at the beginning, making it possible for the user to override those.
I've decided not to push a test, as it require to pull in too many deps and I did not want to pollute the library go.mod
However you can check the test in a dedicated branch I've created: https://github.com/alessio-perugini/otelpgx/tree/test-attribute-override.