feat: add option to disable tracing#60
Merged
obitech merged 2 commits intoexaring:mainfrom Jan 12, 2026
Merged
Conversation
f57635c to
c89e363
Compare
Contributor
Author
|
Hi, @obitech ! After testing, I found that the same result can be obtained by using the noop trace provider and simply checking that the span is not recording. This is a more idiomatic approach in OpenTelemetry, so I removed option in a new commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an option to significantly reduce the overhead caused by tracing instrumentation inside
Tracerimplementation in scenarios where it is not used. Metrics operations will still be performed, and their logic remains unaffected by this change.While otepgx already offers a method to disable tracing by providing a noop traceprovider via option, the operations that prepare trace attributes still remain. Their results will not be used, so these operations are not needed, but they still consume resources.
Here is the benchmark result demonstrating improvements: