Conversation
🦋 Changeset detectedLatest commit: a9371a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @mainqueg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the server's Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughDetects FAILED required onboarding tasks in manteca: Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant getProvider as "getProvider\n(server/utils/ramps/manteca.ts)"
participant Sentry as "Sentry"
Caller->>getProvider: request provider info
getProvider->>getProvider: fetch onboarding tasks
alt any required task == FAILED
getProvider->>Sentry: captureWarning("has failed tasks", context)
getProvider-->>Caller: return ONBOARDING (full currencies, cryptoCurrencies: [])
else no FAILED (pending or none)
getProvider-->>Caller: continue existing flow (NOT_STARTED / ONBOARDING)
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to explicitly handle user onboarding tasks with a 'FAILED' status by introducing a check in the getProvider function in manteca.ts, ensuring these cases are logged to Sentry and the user's status is correctly set to 'ONBOARDING'. A medium-severity security vulnerability has been identified: the error handling now logs a complete user object containing Personally Identifiable Information (PII) to an external service, which requires remediation to protect user data. Additionally, a suggestion has been made regarding a TODO comment for improved long-term maintainability by tracking it in a project management tool.
|
✅ All tests passed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| it("returns ONBOARDING when user has failed required tasks", async () => { | ||
| vi.spyOn(globalThis, "fetch").mockResolvedValueOnce( | ||
| mockFetchResponse({ | ||
| ...mockOnboardingUser, | ||
| onboarding: { | ||
| EMAIL_VALIDATION: { required: true, status: "COMPLETED" }, | ||
| IDENTITY_VALIDATION: { required: true, status: "FAILED" }, | ||
| }, | ||
| }), | ||
| ); | ||
|
|
||
| const result = await manteca.getProvider(account, "AR"); | ||
|
|
||
| expect(result.status).toBe("ONBOARDING"); | ||
| }); |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Strengthen this scenario to lock precedence and response shape.
Add a required PENDING task alongside FAILED and assert onramp fields so this test protects both branch order and payload contract.
♻️ Suggested test hardening
it("returns ONBOARDING when user has failed required tasks", async () => {
vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(
mockFetchResponse({
...mockOnboardingUser,
onboarding: {
- EMAIL_VALIDATION: { required: true, status: "COMPLETED" },
+ EMAIL_VALIDATION: { required: true, status: "PENDING" },
IDENTITY_VALIDATION: { required: true, status: "FAILED" },
},
}),
);
const result = await manteca.getProvider(account, "AR");
expect(result.status).toBe("ONBOARDING");
+ expect(result.onramp.currencies).toEqual(["ARS", "USD"]);
+ expect(result.onramp.cryptoCurrencies).toEqual([]);
});1 participant
Summary by CodeRabbit
Bug Fixes
Tests
Chores