Open
Conversation
patcon
commented
Jan 2, 2025
Comment on lines
+19
to
+21
| pip install git+https://github.com/patcon/polislite.git@python-package | ||
|
|
||
| uv add git+https://github.com/patcon/polislite.git@python-package |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| pip install git+https://github.com/patcon/polislite.git@python-package | |
| uv add git+https://github.com/patcon/polislite.git@python-package | |
| pip install git+https://github.com/eterps/polislite.git@main | |
| uv add git+https://github.com/eterps/polislite.git@main |
patcon
commented
Jan 2, 2025
| "colab_type": "text" | ||
| }, | ||
| "source": [ | ||
| "<a href=\"https://colab.research.google.com/github/patcon/polislite/blob/python-package/polislite_library_usage.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| "<a href=\"https://colab.research.google.com/github/patcon/polislite/blob/python-package/polislite_library_usage.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" | |
| "<a href=\"https://colab.research.google.com/github/eterps/polislite/blob/main/polislite_library_usage.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" |
patcon
commented
Jan 2, 2025
| { | ||
| "cell_type": "code", | ||
| "source": [ | ||
| "!pip install git+https://github.com/patcon/polislite.git@python-package" |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| "!pip install git+https://github.com/patcon/polislite.git@python-package" | |
| "!pip install git+https://github.com/eterps/polislite.git@main" |
patcon
commented
Jan 2, 2025
Comment on lines
+47
to
+53
| "Collecting git+https://github.com/patcon/polislite.git@python-package\n", | ||
| " Cloning https://github.com/patcon/polislite.git (to revision python-package) to /tmp/pip-req-build-b8924s2s\n", | ||
| " Running command git clone --filter=blob:none --quiet https://github.com/patcon/polislite.git /tmp/pip-req-build-b8924s2s\n", | ||
| " Running command git checkout -b python-package --track origin/python-package\n", | ||
| " Switched to a new branch 'python-package'\n", | ||
| " Branch 'python-package' set up to track remote branch 'python-package' from 'origin'.\n", | ||
| " Resolved https://github.com/patcon/polislite.git to commit 9252f24c4acb6ea38a25c1b51b4546d087e91747\n", |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| "Collecting git+https://github.com/patcon/polislite.git@python-package\n", | |
| " Cloning https://github.com/patcon/polislite.git (to revision python-package) to /tmp/pip-req-build-b8924s2s\n", | |
| " Running command git clone --filter=blob:none --quiet https://github.com/patcon/polislite.git /tmp/pip-req-build-b8924s2s\n", | |
| " Running command git checkout -b python-package --track origin/python-package\n", | |
| " Switched to a new branch 'python-package'\n", | |
| " Branch 'python-package' set up to track remote branch 'python-package' from 'origin'.\n", | |
| " Resolved https://github.com/patcon/polislite.git to commit 9252f24c4acb6ea38a25c1b51b4546d087e91747\n", | |
| "Collecting git+https://github.com/eterps/polislite.git@main\n", | |
| " Cloning https://github.com/eterps/polislite.git (to revision main) to /tmp/pip-req-build-b8924s2s\n", | |
| " Running command git clone --filter=blob:none --quiet https://github.com/eterps/polislite.git /tmp/pip-req-build-b8924s2s\n", | |
| " Running command git checkout -b main --track origin/main\n", | |
| " Switched to a new branch 'main'\n", | |
| " Branch 'main' set up to track remote branch 'main' from 'origin'.\n", | |
| " Resolved https://github.com/eterps/polislite.git to commit 9252f24c4acb6ea38a25c1b51b4546d087e91747\n", |
Owner
|
Hi @patcon, I'll review your proposed changes at a later time as I'm currently down with the flu. |
Collaborator
Author
|
Thanks! Pls do rest up. Eager to work with you on this whenever you find time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted it to be more clear how to use this code in a Jupyter Notebook, so I added minimal boilerplate and packaging setup and docs to make that simpler.
(A bunch of places will need the branch and repo updated after approval, but before merge. I'll make suggestions in all those places, but no need to merge them until we're ready, so that others can more easily test)
Here's what's happening:
uvfor package management