Conversation
This is not really finished. Currently mutually exclusive with regular RGBLIGHTING, and not tested with external .lit file.
- add HDR_UnpackE5BRG9 for unpacking - caller is now responsible for scaling 128 -> 1 - expose in header for tests
KurtLoeffler
pushed a commit
to KurtLoeffler/ericw-tools
that referenced
this pull request
Oct 24, 2024
* light: Add support for LIGHTING_E5BGR9. This is not really finished. Currently mutually exclusive with regular RGBLIGHTING, and not tested with external .lit file. * light: replace HDR_PackResult with a version following the OpenGL spec - add HDR_UnpackE5BRG9 for unpacking - caller is now responsible for scaling 128 -> 1 - expose in header for tests * light: move HDR_PackE5BRG9/HDR_UnpackE5BRG9 to common/litfile.hh * build: std::powf not available in gcc * common: move LoadLitFile to litfile.hh * common: LoadLitFile: return hdr variant as well * lightpreview: add an Exposure slider * lightpreview: support hdr .lit's, wip * tests: refactoring to set up testing for hdr lit's * tests: add test for -hdr and -bspxhdr * tests: fix LM_Sample to deal with styles correctly * lightpreview: fix glsl error * lightpreview: show dialog box for glsl compile errors --------- Co-authored-by: Daniel Svensson <dsvensson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping up #421 (and Spike's initial HDR code from #280)
Working in this PR, in Q1 maps:
-hdrto generate a HDR .lit file-bspxhdrto generate a LIGHTING_E5BGR9 BSPX lumpThings that are untested / probably broken:
Definitely not working:
-novanilla+-bspxhdr(the-novanillaseems to be ignored)