Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 397 397
=========================================
Hits 397 397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeremyfell
approved these changes
Sep 9, 2025
| "id": "7b5565cb", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### word of caution...different diffusion coefficient values still give the same CV under E_rev conditions (the beauty of Nernstian kinetics!)" |
Collaborator
There was a problem hiding this comment.
nit: let's format these as full sentences
Suggested change
| "### word of caution...different diffusion coefficient values still give the same CV under E_rev conditions (the beauty of Nernstian kinetics!)" | |
| "### A word of caution: different diffusion coefficient values still give the same CV under E_rev conditions (the beauty of Nernstian kinetics!)." |
Also do we want this text as subheadings (i.e. using ###) or just as regular text? It shows up fairly big in the notebook
| "metadata": {}, | ||
| "source": [ | ||
| "## Example: fit the EE mechanism, now with some known priors\n", | ||
| "### we will assume that diffusion/transfer coefficients were obtained experimentally from RDE, and an educated guess for the ranges of electrochemical rate constants is known" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "### we will assume that diffusion/transfer coefficients were obtained experimentally from RDE, and an educated guess for the ranges of electrochemical rate constants is known" | |
| "### We will assume that diffusion/transfer coefficients were obtained experimentally from the RDE, and an educated guess for the ranges of electrochemical rate constants is known." |
| "id": "0fa7456c", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### the `.fit()` method can optionally receive: a `float` for initial guess of parameter; `tuple[float, float]` for (lower bound, upper bound) of the initial guess; or `tuple[float, float, float]` for (initial guess, lower bound, upper bound)" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "### the `.fit()` method can optionally receive: a `float` for initial guess of parameter; `tuple[float, float]` for (lower bound, upper bound) of the initial guess; or `tuple[float, float, float]` for (initial guess, lower bound, upper bound)" | |
| "### The `fit` method can optionally receive: a `float` for an initial guess of the parameter; `tuple[float, float]` for (lower bound, upper bound) of the parameter; or `tuple[float, float, float]` for (initial guess, lower bound, upper bound)." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.