Optimize Various Functions and Refactor#4
Open
Quantalabs wants to merge 12 commits intoepacuit:masterfrom
Open
Optimize Various Functions and Refactor#4Quantalabs wants to merge 12 commits intoepacuit:masterfrom
Quantalabs wants to merge 12 commits intoepacuit:masterfrom
Conversation
utilize vectorized operations from numpy when calculating margins matrix, as opposed to a nested for loop
Author
|
I added in the tests with 986a806, and the following is the output (running
BFS and DFS now have similar performance. I also reverted by |
Author
Author
Author
|
It seems as though on large amounts of ballots, as in ba56f14, the difference between DFS and BFS is much clearer, and the bi-directional BFS is outperforming DFS. |
Author
|
Finally, the tests for the improved models in b25eceb. All 3 perform better than their old counterparts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






black.coreby using vectorized operations as opposed to the previous nested for loop.I'll try and get some benchmarks to see how much of a performance improvement there is.