Feature/branding column in lines overview #2019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include branding { id, name } in GET_LINES and getFlexibleLinesQuery
to support displaying branding information in the lines overview table.
Part of GitHub #1996 - Adding Branding column to Line overview screen.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add brandingTableHeader translation variable for i18n support - Add Branding column header between Operator and Delete columns - Display branding name in data rows (shows '-' if no branding assigned) - Update colSpan values from 3 to 6 for no-lines and loading states to properly span all 6 columns Part of #1996: Add Branding column to Line overview screen Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add linesBrandingTableHeader translation key to all supported languages: - English: 'Branding' - Norwegian: 'Merkevare' - Swedish: 'Varumärke' - Finnish: 'Brändi' - Bulgarian: 'Марка' Part of #1996 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
Visit the preview URL for this PR (updated for commit 855184d): https://ent-enki-dev--pr2019-feature-branding-col-109iisqy.web.app (expires Fri, 16 Jan 2026 21:08:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 50f71a028b1cba336bad43cc33ce2755ca3f1855 |
|
The column is now present and it is updated accordingly when adding or removing Brandings from lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Add Branding Column to Line Overview Screen
Summary
/lines) and Flexible Lines (/flexible-lines) pagesCloses #1996
Changes
GraphQL Queries
src/api/uttu/queries.ts: Addedbranding { id, name }toGET_LINESquery for fixed linessrc/api/uttu/queries.ts: Addednamefield to existingbrandingselection ingetFlexibleLinesQueryLinesTable Component
src/components/LinesTable/index.tsx:line.branding?.name ?? '-'for each rowcolSpanvalues in loading and empty states (changed from 3 to 6 to properly span all columns)Translations
src/i18n/translations/en.ts: AddedlinesBrandingTableHeader: 'Branding'src/i18n/translations/nb.ts: AddedlinesBrandingTableHeader: 'Merkevare'src/i18n/translations/sv.ts: AddedlinesBrandingTableHeader: 'Varumärke'src/i18n/translations/fi.ts: AddedlinesBrandingTableHeader: 'Brändi'src/i18n/translations/bg.ts: AddedlinesBrandingTableHeader: 'Марка'Test Plan
npx tsc --noEmit)npm run build)npm test)npm run check)/lines(Fixed Lines page)-/flexible-lines(Flexible Lines page)Notes
colSpanvalues in the loading/empty states didn't cover all columns🤖 Generated with Claude Code