Draft
Conversation
Contributor
Author
private async getAttachmentData(url: URL) {
try {
const { response } = await this.httpClient.request(url.href);
return { type: response.headers.get("Content-Type"), size: "10" };
} catch (error) {
this.logger.warn("Couldn't get attachment data", error);
}
}Api 7tv nie odpowiada na HEAD requesty + nie wysyła Domyślam się ze stworzenie osobnego listenera/handlera nie wchodzi w gre, gdyż 2 na raz nasłuchiwały by. Trzeba więc wyosobnić system zdobywania/przesyłania dalej danych zdobytych z attachmentów. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing ground for new embed system in chat, research in what needs to be changed in order to accommodate several chat embeds.
Original 7tv emote preview for design comparison:

Rough mockup of what it would look like(non-square sizes not supported yet):

For now only works for Kick, as this is prototyping only anyway.
Testing
Select all the environments you tested this PR with:
Twitch
Kick