Merged
Conversation
Collaborator
Author
|
Hi @AVHopp, @Scienfitz: I'd say the PR is 95% ready but currently still waiting on the final fixes in #221. But if you like, you can already have a sneak peek and provide some feedback upfront 🙃 |
AdrianSosic
commented
May 7, 2024
d6631de to
ff19f49
Compare
25cdbfa to
48b7cfc
Compare
AdrianSosic
commented
May 13, 2024
4653092 to
3930ef6
Compare
AVHopp
reviewed
May 14, 2024
Collaborator
AVHopp
left a comment
There was a problem hiding this comment.
First round of comments. Have not looked at everything in detail yet.
3930ef6 to
178371b
Compare
Scienfitz
reviewed
May 15, 2024
178371b to
1d856a7
Compare
Scienfitz
reviewed
May 16, 2024
aaed381 to
b812f6c
Compare
Scienfitz
approved these changes
May 16, 2024
AVHopp
approved these changes
May 16, 2024
b812f6c to
95b0f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the GP surrogates into their own subpackage, thereby significantly enhancing configurability:
KernelFactoryprotocol that is now used by the surrogate and enables flexible context-specific construction of kernels.Not included, needs to be done next:
LikelihoodFactoryandMeanFactorymechanisms to give flexible control of the likelihood and mean models