Conversation
AVHopp
commented
Apr 25, 2024
AVHopp
commented
Apr 25, 2024
Scienfitz
reviewed
Apr 25, 2024
Collaborator
Scienfitz
left a comment
Scienfitz
left a comment
There was a problem hiding this comment.
first round of quick comments
AdrianSosic
reviewed
Apr 25, 2024
Collaborator
AdrianSosic
left a comment
AdrianSosic
left a comment
There was a problem hiding this comment.
Hi @AVHopp, here my current feedback. Thanks for drafting 👍🏼
AdrianSosic
reviewed
Apr 26, 2024
Collaborator
AdrianSosic
left a comment
AdrianSosic
left a comment
There was a problem hiding this comment.
@AVHopp: I think the PR is now ready. Could you do a quick rebase to squash all the little fixup commits and then we can merge (unless @Scienfitz has more comments, of course) 🚀
Scienfitz
approved these changes
Apr 26, 2024
AVHopp
force-pushed
the
feature/kernel_priors
branch
from
a67d6a7 to
615b1d9
Compare
AVHopp
commented
Apr 26, 2024
AdrianSosic
approved these changes
Apr 29, 2024
AVHopp
force-pushed
the
feature/kernel_priors
branch
from
9bc864b to
a8cf2a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces custom priors for kernels. It provides an ABC
Prioras well as aGammaPriorclass and corresponding tests.Note that this PR does not yet introduce custom
ScaleKernelsand only adjusts the priors at the point where they are used for our customMaternKernels. At other parts of the code, we technically still use the originalGPyTorchpriors, which is a bit hidden by the.to_gyptorch()call. This will all be fixed in upcoming PRs.Further note that the kernel serialization currently fails. @AdrianSosic and I already briefly investigated the error and did not manage to track it down, and agreed to investigate this issue once the code is pushed (which is the case now)