Conversation
b3c9ae2 to
185d682
Compare
19910a7 to
b1f6faf
Compare
AdrianSosic
left a comment
There was a problem hiding this comment.
Just a few minor comments
2f230a1 to
5ecd3cc
Compare
|
@AdrianSosic @Scienfitz I force pushed the newest version. Please have a very quick look if this is gucci for you and ping me if this can be merged. Explicitly re-asking due to the upload of the svg files and how the potential override of files is handled. |
5ecd3cc to
bb654f5
Compare
|
@AdrianSosic I am finally done with this. Some things have changed a bit:
If you are happy with the current version, feel free to just merge. |
515ff34 to
63288de
Compare
AdrianSosic
left a comment
There was a problem hiding this comment.
Hey @AVHopp, due to the new changes, there a couple (minor) open issues.
63288de to
999555a
Compare
Scienfitz
left a comment
There was a problem hiding this comment.
resetting the review and will reevaluate
70c5fad to
b8b8500
Compare
b8b8500 to
6dad852
Compare
18f507d to
befed82
Compare
AdrianSosic
left a comment
There was a problem hiding this comment.
Will simply approve to unblock you. There's one minor open issue with the lazy imports that you guys still need to figure out. Other than that, I didn't fully follow your other conversations because of my absence, so I'll simply trust you there ;)
caf247d to
7170a9f
Compare
6b7b76b to
5de7c42
Compare
This PR introduces including plots in the examples in light and dark version.
The requirement is that suitable .svg files are contained in the corresponding example folders. These need to be named like the example itself, together with "_light" and "_dark". Note that both of these files need to be present.
In addition, this PR changes the
botorch_analytical.pyexample to show how corresponding files can be created automatically using a pre-defined .json. Furthermore, the file is changed in such a way to demonstrate the use of aSMOKE_TESTenvironment variable.