Before you could not add text to progessbars. With this minor fix you ca...#121
Open
toovy wants to merge 2 commits intoember-addons:masterfrom
Open
Before you could not add text to progessbars. With this minor fix you ca...#121toovy wants to merge 2 commits intoember-addons:masterfrom
toovy wants to merge 2 commits intoember-addons:masterfrom
Conversation
… can use the block helpers of bs-progress and bs-progressbar to create progress bars with custom text.
Collaborator
|
@toovy Why not just replace the Complete text to a property ? |
Author
|
@asaf the span.sr-only is only detected by screen readers afaik. That would not solve the problem. As seen here http://getbootstrap.com/components/#progress you can add text directly under the div.progress-bar. Furthermore the problem is that you might want to add even more dynamic segments to the output. See this example: |
Collaborator
|
@toovy Fair enough, I am not committing yet because the documentation needs to get updated first, If you have time then feel free to add this code sample into the docs or I'll do it later, Thanks! |
Author
|
@asaf I've added a small chapter, hope that it is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the block helpers of bs-progress and bs-progressbar to create progress bars with custom text.