Open
Conversation
added 2 commits
October 31, 2014 14:38
Contributor
|
Currently Behat is used for testing. I'm not opposed to any other types of tests being added, as long as they are stable. Caching the services JSON is a great idea. I'll have a look at these commits this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How would you feel about allowing users to cache the services JSON for a certain amount of time (default being 1 day) if they specifity a cache file?
I'd write some unit tests but there isn't a framework yet that I can see. I can add some phpunit stuff if it helps?