Merged
Conversation
Member
Author
|
@dmarkow thank you for PR! |
achempion
force-pushed
the
feature/2019-09-11-nil-url-for-skipped-versions
branch
from
632215b to
11df967
Compare
achempion
deleted the
feature/2019-09-11-nil-url-for-skipped-versions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to address the stavro/arc_ecto#117
from @dmarkow:
I added a PR to Arc last year that allows skipping versions (for example, an attachment uploader that only generates
:thumbversions for files that support it).I just realized I never submitted this PR to deal with the nil urls that Arc now returns for these skipped versions (before this PR, there would be an error trying to
URI.parse(url)onnil).