You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not entirely sure how to test this yet, but it does compile now and open in the browser. I need to find the equivalent to setView for the X11 environment, which may be more involved than the simple API provided by macOS and Windows.
Fantastic @erik-nilcoast thank you so much! I took a quick pass and generally this looks great. I see what you mean on the view handle piece. I saw this bit in the JUCE docs for that XEmbedComponent:
This is how you embed a GTK+ widget: if you are using the client initiated version of the protocol, then create a new gtk widget with gtk_plug_new (0). Then query the window id of the plug via gtk_plug_get_id(). Pass this id to the constructor of this class.
So I think perhaps, call getViewHandle on the webview, then try to cast it to GtkWidget* (as shown here: https://github.com/Tracktion/choc/blob/main/gui/choc_WebView.h#L332), then perhaps we can use gtk_plug_get_id() from that GtkWidget*? And if so, we can pass it into the constructor for the XEmbedComponent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how to test this yet, but it does compile now and open in the browser. I need to find the equivalent to
setViewfor the X11 environment, which may be more involved than the simple API provided by macOS and Windows.