Refactor batch retry tests to verify behavior instead of implementation details#165
Draft
Copilot wants to merge 3 commits intofeature/batch-too-large-retriesfrom
Draft
Refactor batch retry tests to verify behavior instead of implementation details#165Copilot wants to merge 3 commits intofeature/batch-too-large-retriesfrom
Copilot wants to merge 3 commits intofeature/batch-too-large-retriesfrom
Conversation
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for retries with smaller batch sizes
Refactor batch retry tests to verify behavior instead of implementation details
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch retry tests in
PersistentActorUpdateEventProcessorTestwere verifying internal method call counts (e.g.,insertStatement.bind()called exactly 6 times) rather than actual behavior. This makes tests brittle and prone to breaking when refactoring implementation while preserving functionality.Changes
testProcessBatchTooLargeWithTwoEvents,testProcessBatchTooLargeWithThreeEvents, andtestProcessBatchTooLargeWithNineEventseventshadowed class fieldBefore
After
Tests now assert on observable behavior (retry mechanism splits batch and processes events) rather than internal implementation details.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.