Refactor test to verify behavior instead of implementation details#164
Merged
jwijgerd merged 2 commits intofeature/batch-too-large-retriesfrom Dec 31, 2025
Merged
Conversation
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on support for retries
Refactor test to verify behavior instead of implementation details
Dec 26, 2025
jwijgerd
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
testProcessBatchTooLargeWithNineEventswas asserting thatinsertStatement.bind()is called exactly 18 times for 9 events, coupling the test to internal implementation details. This makes the test brittle—any optimization or refactoring that changes how often bind is called would break the test even if behavior remains correct.Changes
insertStatement.bind()calls (was:times(18))atLeast(2)to verify retry mechanism triggers without prescribing exact retry countThe test now validates that:
This follows the principle of testing observable behavior rather than internal mechanics.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.