handle --force when checking for incorrect password#196
Merged
Conversation
andreineculau
commented
Feb 24, 2025
Collaborator
|
This looks like a good improvement thanks, but I'm getting test failures in cases where a newly-created repository doesn't yet have a HEAD reference:
We will need to find a variant of the dirty files check command that works in this scenario. Note that I moved the duplicated dirty file check command into a reusable function |
andreineculau
commented
Mar 14, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
andreineculau
commented
Mar 15, 2025
8b5acc2 to
49b346a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare dirty before and after. see #195 (comment)
PS: switched to the same dirty check we have in run_safety_checks for consistency