better support for git worktree#186
Open
andreineculau wants to merge 2 commits intoandreineculau-patch-1from
Open
better support for git worktree#186andreineculau wants to merge 2 commits intoandreineculau-patch-1from
andreineculau wants to merge 2 commits intoandreineculau-patch-1from
Conversation
…config path instead of `--git-dir`
Collaborator
|
Thanks for this, I have extended your change so transcrypt (and tests) uses the Does this change make sense? And does it get transcrypt closer to working properly with worktrees (with the caveat you mentioned)? |
Collaborator
Author
|
Looks good 👍 |
|
Works for me, nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running
git worktree add some-branch some-branchin a transcrypted repository fails because the "common" config will point to a .git/worktrees/some-branch/transcrypt instead of .git/worktrees/transcryptthis fix is half-baked because it then makes it impossible to activate transcrypt only inside 1 worktree, but overall it makes sense