added context manager / decorator for transactions [WIP]#1087
Draft
beniwohli wants to merge 2 commits intoelastic:mainfrom
Draft
added context manager / decorator for transactions [WIP]#1087beniwohli wants to merge 2 commits intoelastic:mainfrom
beniwohli wants to merge 2 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
basepi
reviewed
Jun 14, 2021
Contributor
basepi
left a comment
basepi
left a comment
There was a problem hiding this comment.
This looks awesome so far. What's left?
kalemas
reviewed
Nov 19, 2022
| def __call__(self, func): | ||
| self.name = self.name or get_name_from_func(func) | ||
|
|
||
| @functools.wraps(func) |
Contributor
There was a problem hiding this comment.
Is it possible to use wrapt here?
Contributor
There was a problem hiding this comment.
Btw does it makes sense to PR on this PR? As this implementation lacks some useful cases.
Contributor
There was a problem hiding this comment.
@kalemas You're welcome to make a PR, though this PR is pretty out of date so it might make more sense to wait until @beniwohli gets back to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Related issues
closes #ISSUE