Skip to content

Quick proof-of-concept that strips unnecessary deserialization calls#3138

Draft
chrisdennis wants to merge 1 commit intoehcache:masterfrom
chrisdennis:remove-all-deser
Draft

Quick proof-of-concept that strips unnecessary deserialization calls#3138
chrisdennis wants to merge 1 commit intoehcache:masterfrom
chrisdennis:remove-all-deser

Conversation

@chrisdennis
Copy link
Member

This is a draft PR of a proof-of-concept that eliminates value deserialization from the removeAll call (and maybe some other things). There are two things that make this only a PoC:

  1. The code is ugly and could do with a bunch of cleanup/rationalization.
  2. I made no attempt to confirm that any "moved" deserialization happens safely when deserializing data pulled from offheap/disk. If we delay these deserializations too much then we may pull them outside of the relevant lock scope without taking defensive copies of the data. This could (or more likely would) lead to corruption under heavy multi-threaded access that may not be detected by the tests.

Before this is merged someone needs to go over this code to assess its safety on these dimensions (and cleanup up the general dogs dinner I left behind during my hacking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant