accommodate "NAs" spelling from R-devel#151
Merged
edzer merged 1 commit intoedzer:mainfrom Jan 23, 2026
Merged
Conversation
Owner
|
Great, thanks! |
bastistician
added a commit
to bastistician/sp
that referenced
this pull request
Jan 23, 2026
to avoid output differences with new character summaries in R-devel also tweak the print() kludge from edzer#151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal patch to resolve differences from reference output in tests due to the recent "NA's" -> "NAs" fix in R-devel's
summarymethods (cf. PR#18948).Next step after this is merged should be to also take care of output differences due to the new default summary for character vectors (cf. PR#16750) that affects
tests/pass1.Rout.save. I'd argue that this reveals a regression in sp for R >= 4.0.0:SpatialLines2SpatialPointsDataFrameshould really consistently produceLines.IDas a factor. I could prepare a PR for that as well.