This repository was archived by the owner on Dec 8, 2020. It is now read-only.
config: Do not treat RLS as a special case for running cargo in terminal#361
Open
abronan wants to merge 1 commit intoeditor-rs:masterfrom
Open
config: Do not treat RLS as a special case for running cargo in terminal#361abronan wants to merge 1 commit intoeditor-rs:masterfrom
abronan wants to merge 1 commit intoeditor-rs:masterfrom
Conversation
Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
abronan
force-pushed
the
rls_cargo_terminal
branch
from
83f6f16 to
107b093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283
I used to compile my own extension from the sources with that modification in order to be able to not run cargo in terminal using RLS.
I think it makes sense not to treat RLS as a special case here and use the configuration option as intended (with
rust.executeCargoCommandInTerminal).