Fix Header Tool not supporting line breaks#74
Open
mrspence wants to merge 2 commits intoeditor-js:masterfrom
Open
Fix Header Tool not supporting line breaks#74mrspence wants to merge 2 commits intoeditor-js:masterfrom
mrspence wants to merge 2 commits intoeditor-js:masterfrom
Conversation
Allow a Header Tool's text to include break line `<br>` tags when a user presses Shift + Enter.
By default, this is disabled, the developer can choose to enable through the tool's config:
```
config: {
allowLineBreaks: true,
}
```
Fixes editor-js#73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue?
Currently the Header Tool does not support line breaks like other Tools do. Normally a user can press Shift + Enter which adds a line break. However at the moment this tool strips line breaks out.
This pull request fixes:
<br>when shift+enter pressed - editor-js/header repoSolution
This pull request adds a config parameter
allowLineBreaks: {Boolean}that allows the developer to enable line breaks should they need.By default, line breaks are not enabled, as per the current status quo.