Introduce bias/diff maps and animations#1912
Open
SavvasMel wants to merge 3 commits intoecmwf:developfrom
Open
Introduce bias/diff maps and animations#1912SavvasMel wants to merge 3 commits intoecmwf:developfrom
SavvasMel wants to merge 3 commits intoecmwf:developfrom
Conversation
Contributor
Author
iluise
reviewed
Feb 25, 2026
| if not isinstance(plot_maps, bool): | ||
| raise TypeError("plot_maps must be a boolean.") | ||
|
|
||
| plot_bias_maps = plot_settings.get("plot_bias_maps", False) |
Collaborator
There was a problem hiding this comment.
I would enable it by default to True like plot_target now that the differences are so small.
Minor: can we change the name to plot_bias or plot_diff to match with plot_target ?
| maps_config.update({var: {"vmax": float(max(list_max)), "vmin": float(min(list_min))}}) | ||
|
|
||
| return maps_config | ||
| # Compute symmetric bias (preds - tars) ranges |
Collaborator
There was a problem hiding this comment.
Can we split it into two functions? I think it will help readability and the two parts do not seem to be related right?
| if not isinstance(global_plotting_opts.get(stream), oc.DictConfig): | ||
| global_plotting_opts[stream] = oc.DictConfig({}) | ||
| maps_config = common_ranges( | ||
| maps_config, bias_maps_config = common_ranges( |
Collaborator
There was a problem hiding this comment.
very minor: same here, I'd shorted it to bias_config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR introduces the creation of diff maps (pred-target) or otherwise bias maps. Animations of those are also introduced in this PR.
Add to config the below:
Issue Number
Closes #1772
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60