Skip to content

[1990] Fix the EnumerationDefinition compartment name according to specification#2064

Merged
AxelRICHARD merged 1 commit intomainfrom
gco/fix/1990
Mar 13, 2026
Merged

[1990] Fix the EnumerationDefinition compartment name according to specification#2064
AxelRICHARD merged 1 commit intomainfrom
gco/fix/1990

Conversation

@gcoutable
Copy link
Member

@gcoutable gcoutable commented Mar 12, 2026

Bug: #1990
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.3.0 milestone Mar 12, 2026
@gcoutable gcoutable linked an issue Mar 12, 2026 that may be closed by this pull request
@gcoutable gcoutable requested a review from AxelRICHARD March 12, 2026 16:20
@AxelRICHARD
Copy link
Member

The build failure seems not related with your PR

@gcoutable
Copy link
Member Author

gcoutable commented Mar 13, 2026

The build failure seems not related with your PR

The test was false, I think I fixed it.
It passes locally on both Firefox and Chromium, so we will see what results the CI will give us.

…ecification

Bug: #1990
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@AxelRICHARD AxelRICHARD merged commit 1bbf9ba into main Mar 13, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gco/fix/1990 branch March 13, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enumerations compartment name is wrong

2 participants