[2042] Improve error reporting while uploading a document#2044
Open
adaussy wants to merge 1 commit intoeclipse-syson:mainfrom
Open
[2042] Improve error reporting while uploading a document#2044adaussy wants to merge 1 commit intoeclipse-syson:mainfrom
adaussy wants to merge 1 commit intoeclipse-syson:mainfrom
Conversation
AxelRICHARD
reviewed
Mar 10, 2026
| assertTrue(optExternalResourceLoadingResult.isPresent()); | ||
|
|
||
| if (!this.expectedErrorMessages.isEmpty()) { | ||
| LoadingReport report = (LoadingReport) optExternalResourceLoadingResult.get().loadingReport(); |
Member
There was a problem hiding this comment.
optExternalResourceLoadingResult.get() is already affected to a variable below. Please use this variable.
| System.err.println("Error while parsing input file : " + errorMessage); | ||
| AstParsingResult astResult = sysmlToAst.convert(inputStream, "sysml"); | ||
|
|
||
|
|
| .collect(Collectors.joining(System.lineSeparator(), System.lineSeparator(), System.lineSeparator())); | ||
| System.err.println("Error while parsing input file : " + errorMessage); | ||
| } | ||
|
|
| } | ||
|
|
||
| private List<Element> convert(InsertTextualSysMLv2Input insertTextualInput, IEMFEditingContext emfEditingContext, ASTTransformer tranformer, Element parentElement) { | ||
| private List<Element> convert(InsertTextualSysMLv2Input insertTextualInput, IEMFEditingContext emfEditingContext, ASTTransformer tranformer, Element parentElement, List<Message> messages) { |
CHANGELOG.adoc
Outdated
| - https://github.com/eclipse-syson/syson/issues/2032[#2032] [export] Fix NPE when exporting `LiteralString`. | ||
| - https://github.com/eclipse-syson/syson/issues/2037[#2037] [export] Backslashes need to be escaped during textual export in `LiteralString`. | ||
| - https://github.com/eclipse-syson/syson/issues/2039[#2039] [import] Import should unescape backslash in `LiteralString`. | ||
| - https://github.com/eclipse-syson/syson/issues/2042[#2042] [import] Improve error reporting while uploading a document. |
Member
There was a problem hiding this comment.
why it is in Bug fixes section ? Improvements seems more appropriate
Bug: eclipse-syson#2042 Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #2042
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests