Open
Conversation
Signed-off-by: Aswathy S Kumar <aswathyskumar144@gmail.com>
keithc-ca
requested changes
Feb 9, 2026
| // test resources | ||
| cleanDirsStr += " ${buildWorkspace}/../../" | ||
| cleanDirsStr += cleanDirs.join(" ${buildWorkspace}/../../") | ||
| cleanDirsStr += " /cygdrive/c/temp/${cleanDirs.join(' /cygdrive/c/temp/')}" |
Contributor
There was a problem hiding this comment.
I think this should use the relevant environment variable(s) (e.g. TEMP mentioned in the description) instead of hard-coding that path.
Contributor
Author
There was a problem hiding this comment.
@keithc-ca I have made the correction. Can I go ahead and squash the commits?
Signed-off-by: Aswathy S Kumar <aswathyskumar144@gmail.com>
keithc-ca
requested changes
Feb 25, 2026
| // test resources | ||
| cleanDirsStr += " ${buildWorkspace}/../../" | ||
| cleanDirsStr += cleanDirs.join(" ${buildWorkspace}/../../") | ||
| cleanDirsStr += " ${tempDir}/${cleanDirs.join(" ${tempDir}/")}" |
Contributor
There was a problem hiding this comment.
I don't expect tempDir is accessible here; it should be defined here.
Variable references should use ${}.
Double-quotes don't nest (on line 169).
I suggest we need to supply a default for TEMP:
def tempDir = "${env.TEMP}" ?: "/cygdrive/c/temp"
// convert to unix path
tempDir = sh(script: "cygpath -u '${tempDir}'", returnStdout: true).trim()
cleanDirsStr += " ${tempDir}/${cleanDirs.join(' ${tempDir}/')}"
Contributor
|
Please rebase to avoid implicit merges (e.g. with #23311). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current cleanup script only removes temporary files from the /tmp directory, which is insufficient for Windows machines running Jenkins agents. Some Windows machines are getting disconnected due to low disk space. Upon investigation, it was found that C:\temp (or the directory specified by the TEMP environment variable) accumulates around 75GB of data, causing disk space exhaustion.
To resolve this, the cleanup script needs to be enhanced to include commands for clearing files from C:\temp or the machine’s designated TEMP directory. This will help prevent disconnections and ensure consistent performance of Jenkins agents by freeing up disk space
#https://github.ibm.com/runtimes/infrastructure/issues/10482