Add Helm Operator for OpenJ9 JITServer#81
Add Helm Operator for OpenJ9 JITServer#81agarwalrounak wants to merge 5 commits intoeclipse-openj9:masterfrom
Conversation
Signed-off-by: Rounak Agarwal <rounag16@in.ibm.com>
mpirvu
left a comment
There was a problem hiding this comment.
Can a user get the two yaml file without cloning this entire openj9-utils repo?
We need some documentation on how to change the Java version for JITServer. Moreover, what happens if a user needs to have a JITServer with Java8 and a JITServer with Java11? We need two different JITServer deployments.
Signed-off-by: Rounak Agarwal <rounag16@in.ibm.com>
mpirvu
left a comment
There was a problem hiding this comment.
Could you please add license information much like the helm files have?
Signed-off-by: Rounak Agarwal <rounag16@in.ibm.com>
Signed-off-by: Rounak Agarwal <rounag16@in.ibm.com>
mpirvu
left a comment
There was a problem hiding this comment.
LGTM. One I have is about the particle 'sample' in the name of the JITServer service/deployment/pod. E.g. service/openj9jitserverchart-sample-openj9-jitserver-chart
How is the name being constructed?
I also feel there is a bit of redundancy between "openj9jitserverchart" and "openj9-jitserver-chart"
|
In service.yaml from the jitserver helm chart templates,
Thus, the name translates to |
|
The |
Signed-off-by: Rounak Agarwal <rounag16@in.ibm.com>
Signed-off-by: Rounak Agarwal rounag16@in.ibm.com