Functional Implementation of the 2023-06-15-preview API#333
Open
michael-sabrnak-swi wants to merge 8 commits intoebourg:masterfrom
Open
Functional Implementation of the 2023-06-15-preview API#333michael-sabrnak-swi wants to merge 8 commits intoebourg:masterfrom
michael-sabrnak-swi wants to merge 8 commits intoebourg:masterfrom
Conversation
Try to use new API
- Added header-aware RESTResponse return path in RESTClient so callers can access operation metadata (status code, headers, parsed body, raw bytes) without reimplementing HTTP plumbing.
- Updated AzureTrustedSigningService to use the new RESTResponse, read Azure’s operation-location header, and poll the returned /sign/{operationId} URL until completion.
- Adjusted the Azure Trusted Signing tests to simulate the :sign POST plus header-driven polling flow, ensuring certificate-chain fetch, signing success/failure, and timeout cases all match the real API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was raised in response to #332.
Here’s a quick before/after rundown between Azure Trusted Signing’s 2022-style flow and the
2023-06-15-previewversion:Endpoint shape
.../certificateprofiles/{profile}/sign(no colon)..../certificateprofiles/{profile}:signfor the initial POST, while the poll endpoint moves to/sign/{operationId}and is advertised via headers. More details here.Operation metadata
Response contract
InProgress, with the real signature only available after polling the operation URL untilstatus == "Succeeded"; errors now come in theerrorDetail/errorsenvelope.Payload subtleties
digest, optional additional hash lists) plus stricter algorithm names (RS256, ES256, etc.) - the refactor clamps inputs to what the preview API accepts.Client behavior
AzureTrustedSigningService, and reworked tests to mimic that asynchronous lifecycle.