Skip to content

More weakref fixes#198

Open
rozyczko wants to merge 5 commits intodevelopfrom
more_weakref_fixes
Open

More weakref fixes#198
rozyczko wants to merge 5 commits intodevelopfrom
more_weakref_fixes

Conversation

@rozyczko
Copy link
Member

Some callers iterate over __type_dict while other threads or weakref finalizers may modify it. Creating a list snapshot (with a retry loop) prevents RuntimeError: dictionary changed size during iteration.

This should FINALLY get rid of this pesky issue.

- STACK.md - Technologies and dependencies
- ARCHITECTURE.md - System design and patterns
- STRUCTURE.md - Directory layout
- CONVENTIONS.md - Code style and patterns
- TESTING.md - Test structure
- INTEGRATIONS.md - External services
- CONCERNS.md - Technical debt and issues
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['[scope] bug', '[scope] enhancement', '[scope] documentation', '[scope] significant', '[scope] maintenance']

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) [area] global_object Anything related to the global_object [priority] highest Urgent. Needs attention ASAP labels Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.11%. Comparing base (bd10653) to head (03631c2).

Files with missing lines Patch % Lines
src/easyscience/global_object/map.py 84.61% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
- Coverage    81.15%   81.11%   -0.05%     
===========================================
  Files           52       52              
  Lines         4267     4279      +12     
  Branches       740      740              
===========================================
+ Hits          3463     3471       +8     
- Misses         624      628       +4     
  Partials       180      180              
Flag Coverage Δ
unittests 81.11% <84.61%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/global_object/map.py 95.16% <84.61%> (-1.76%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] global_object Anything related to the global_object [priority] highest Urgent. Needs attention ASAP [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants