Improve performance by skipping bytes instead of parsing again on a second pass (or first)#17
Open
dkomanov wants to merge 3 commits intoeaftan:masterfrom
Open
Improve performance by skipping bytes instead of parsing again on a second pass (or first)#17dkomanov wants to merge 3 commits intoeaftan:masterfrom
dkomanov wants to merge 3 commits intoeaftan:masterfrom
Conversation
In local tests it showed improvement: 34 seconds -> 24 seconds for 2GB heap dump.
Author
|
This is how primArrayDump optimization would look like: dkomanov@81891b2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 2GB heap dump:
Baseline performance (ParallelGC is much better):
After optimizations:
Other possible optimizations:
BufferedInputStream. Tried it, at most 200 milliseconds gain (variability is bigger).primArrayDumpinterface to use native primitive arrays instead ofValue<?>[]. It gives significant gain: 16 seconds against 24 seconds.