Add usage overview for questionnaires#2599
Open
hansegucker wants to merge 2 commits intoe-valuation:mainfrom
Open
Add usage overview for questionnaires#2599hansegucker wants to merge 2 commits intoe-valuation:mainfrom
hansegucker wants to merge 2 commits intoe-valuation:mainfrom
Conversation
Member
richardebeling
left a comment
There was a problem hiding this comment.
lgtm, but I think we shouldn't spend resources to remove the breadcrumb link
9f1add6 to
cd6941a
Compare
cd6941a to
e840a04
Compare
e840a04 to
1550f9b
Compare
niklasmohrin
reviewed
Feb 9, 2026
Member
niklasmohrin
left a comment
There was a problem hiding this comment.
Looks mostly good, thanks!
richardebeling
approved these changes
Feb 16, 2026
niklasmohrin
approved these changes
Feb 16, 2026
Member
There was a problem hiding this comment.
It looks a bit strange that all rows have a bottom border, but there is no top border. @janno42 can decide how this should look
Member
There was a problem hiding this comment.
please remove the bottom border on the last tr
janno42
requested changes
Mar 2, 2026
Comment on lines
+14
to
+18
| {% blocktrans with semester_name=semester.name count n=evaluations|length %} | ||
| {{ n }} usage in {{ semester_name }} | ||
| {% plural %} | ||
| {{ n }} usages in {{ semester_name }} | ||
| {% endblocktrans %} |
Member
There was a problem hiding this comment.
In the header, please only include the semester name followed by a badge rounded-pill with the number of usages, as seen on the filter buttons on the semester index page.
Member
There was a problem hiding this comment.
please remove the bottom border on the last tr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2585