fix #2555 language x in preview#2556
Draft
Jakobus400 wants to merge 4 commits intoe-valuation:mainfrom
Draft
Conversation
Member
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
we also still need a test that checks that accessing the page works :)
Member
|
one more thing: the magic "fix #..." line should be in the PR description, not the PR title or commit message. You can still change this, and then you will see that this PR will be automatically linked to the issue in the "Development" section on the right of the page. |
niklasmohrin
requested changes
Dec 1, 2025
Member
niklasmohrin
left a comment
niklasmohrin
left a comment
There was a problem hiding this comment.
code looks good, but still needs tests
Member
|
Hi @Jakobus400, do you want to continue with this or should we take over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2555 Preview of evaluation form failed with undecided language. Fixed by checking in render_vote_page()