Conversation
|
Thanks for your PR! Is it possible to move your Javascript functions outside of the |
I added 2 functions:
I am a noob at angularjs but i dont understand how and why to move a function of an object / prototype to an other file. |
I am the maintainer of the Flowupload app for Nextcloud which uses ng-flow extensively. Recently @TessyPowder added two functions to ng-flow which adds a counter for all files and a function to count already uploaded chunks. I would like to bring these changes to upstream so other projects can use them as well and so they are in the right place. The original PR on my repository can be found here: e-alfred/flowupload#57
|
Hello, I proposed your changes to the upstream project (ng-flow) so they can be integrated into the official ng-flow-standalone.js library. Here is the link: This will make maintaining and upgrading these libraries easier because they wouldn't depend on changes that would have to be made everytime the library gets updated. |
|
I merge this, hopefully it will be included upstream in the future. Thanks @JonathanTreffler! |

I think it would be cool to have a label that shows the overall progress of the flowupload upload. So i added it.
The flow object already has a progress function.
I just added a function to the flow object that returns the number of files being uploaded (including already finished files) to be able to hide the progress label if there are no files selected.
Its a really small change but i think its quite nice to have.
I often use flowupload to upload hundreds of Gigabyte and i dont want to scroll over the whole page to see the progress