Feature #569 ROC diagram, reliability diagram, and ens_ss - plotly to matplotlib#570
Merged
georgemccabe merged 106 commits intofeature_555_replace_plotlyfrom Mar 13, 2026
Merged
Conversation
* Updated the release_date * Removed the -rc1 suffix for coordinated release * Updated for coordinated release * Rotate authorship for coordinated release * Update year of copyright date * Per #550, modify formatting of release notes header * Per #550, attempting to resolve SonarQube error with regard to coverage Add source and omit settings for coverage tool * Per #550, correcting syntax Updated source paths for coverage tool and adjusted omit settings. * Per #550, update coverage omit pattern for _netCDF4.pyx * Per #550, another attempt to resolve the SonarQube error * Per #550, another attempt to resolve the SonarQube error Updated coverage configuration to omit specific files. * Update pyproject.toml move the omit from the tool.coverage.report to the tool.coverage.run to see if the histogram_2d/src/netCDF4 can be omitted from the trace * Update pyproject.toml try [run] source=. to prevent measuring code outside of project * remove the [run] block, this causes issues with another GHA * add source=. to only check the METplotpy source code and not third party libraries * Use different syntax to omit the histogram_2d/src from report * Return to original state, moved omit to the .coveragec config * Update pyproject.toml remove extraneous line * Update release-notes.rst * Update conf.py --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
… Matplotlib support
…g.py. Updated plots that use plotly to import from those versions so it is clear which plots still rely on plotly and need to be updated. This will also allow optional support of plotly for certain plots if we are not able to fully get rid of the plotly dependency in this development cycle. Also removed some unused imports. Replaced util.py function apply_weight_style with get_font_params since the existing version will not be able to be used with matplotlib
…y matplotlib. Instead set xaxis label weight similar to taylor_diagram logic
…and_common_functionality
…feature_556_copy_base_and_common_functionality
…tring 9999 to integer 9999 and use np.nan instead of string 'NA'
…causes yaml configurations for lines to be ignored
…feature_556_copy_base_and_common_functionality
…and_common_functionality
update copyright year
…s://github.com/dtcenter/METplotpy into feature_556_copy_base_and_common_functionality
…feature_556_copy_base_and_common_functionality
…ght date and information.
…and_common_functionality
…units. added helper function to reduce duplication for logic to convert units
…plotly version for now
…l and y-axis label style, weight, and font size. Moved the add_horizontal_line() and add_vertical_line() code from the util.py module to this module as this will be needed for all plot types. TODO comments are used to denote code that will need to be removed when all plot types have migratee to Matplotlib.
…s://github.com/dtcenter/METplotpy into feature_556_copy_base_and_common_functionality
…_ss from properly adding y2 axis
…p for easier review
…to properly handle the x value locations for some plots to use the actual values instead of an index 0-n
23 tasks
bikegeek
reviewed
Mar 12, 2026
bikegeek
reviewed
Mar 13, 2026
| Args: | ||
| Returns: | ||
| """ | ||
| # set the range of the x-axis and y-axis to range from 0 to 1 |
Collaborator
There was a problem hiding this comment.
are lines 311 and 312 needed? they are the same and are commented out
Contributor
Author
There was a problem hiding this comment.
I had left this code commented to check if I needed to add similar functionality using matplotlib.
It looks like the ROC diagram plots showed values from 0-1 already, but I added explicit limits for the x- and y-axis to ensure that it always is. Currently, the xticks don't default to 0-1 by 0.1, but I could add something to force this if the indy_labels/vals are not set.
bikegeek
reviewed
Mar 13, 2026
bikegeek
reviewed
Mar 13, 2026
| # )) | ||
|
|
||
| self.logger.info(f"Finished creating figure: {datetime.now()}") | ||
| # can't support number of columns in legend, can only choose |
Collaborator
There was a problem hiding this comment.
lines 328-335 are commented out, is this code still useful?
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, this isn't doing anything that isn't already supported, but maybe I don't understand what its intention is. I removed it, but let me know you think I should revisit this.
bikegeek
reviewed
Mar 13, 2026
Collaborator
bikegeek
left a comment
bikegeek
left a comment
There was a problem hiding this comment.
just a few minor comments, I'll let you decide whether to heed them or not.
Removed commented-out code for series plotting.
…functionality covered in those code blocks -- set x- and y-axis limits to 0-1 for ROC diagram plots and use draw_box config variable to determine if box around legend should be displayed or not
bikegeek
approved these changes
Mar 13, 2026
bikegeek
approved these changes
Mar 13, 2026
georgemccabe
merged commit 9b3bf89
into
feature_555_replace_plotly
13 of 15 checks passed
github-project-automation
bot
moved this from 🔎 In review
to 🏁 Done
in METplus-7.0 Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases